fix the device performance timing checks for clReleaseContext #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The device performance timing checks were only supposed to happen when the context reference count went to zero, but because the reference count was only queried when call logging was enabled, it was happening much more often. Fix by querying (and updating) the context reference count unconditionally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The device performance timing checks were only supposed to happen when the context reference count went to zero, but because the reference count was only queried when call logging was enabled, it was happening much more often. Fix by querying (and updating) the context reference count unconditionally.
Testing Done
Tested with the SYCL llama.cpp with just chrome tracing enabled. Verified that the device performance timing checks did not occur for calls to clReleaseContext.